gh-123284: fix _pylong decimal context creation#123285
Closed
picnixz wants to merge 2 commits into
Closed
Conversation
picnixz
changed the title
_pylong decimal context creation (and refleaks)_pylong decimal context creation
vstinner
reviewed
Sep 5, 2024
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
This change is maybe hidden the problem, but I don't think that it's a fix: #123284 (comment)
I don't think that _pylong.py code is wrong.
Member
Author
|
Converting into draft until I solved the original issue. |
Member
Author
|
Actually, this will be fixed by #123703 because what's missing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also makes
_pylongno longer leak references due to the contextvars indecimal, although_pydecimal(and_decimal) will still leak once we calldecimal.getcontext()._pylonghas side effects ondecimal#123284